Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace np float and int #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace np float and int #17

wants to merge 1 commit into from

Conversation

augeorge
Copy link

@augeorge augeorge commented May 8, 2024

No description provided.

@augeorge augeorge requested a review from djinnome May 8, 2024 03:00
@augeorge augeorge linked an issue May 8, 2024 that may be closed by this pull request
numpy deprecation #16
Open
djinnome
djinnome reviewed May 8, 2024
View reviewed changes
Copy link
Member

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to modify SERGIO to deprecate numpy, why not modify SERGIO so that it uses gene names instead of indices?

djinnome
djinnome reviewed May 8, 2024
View reviewed changes
Copy link
Member

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm that SERGIO still produces expected output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djinnome djinnome djinnome left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

numpy deprecation
2 participants
@augeorge @djinnome